Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for Session set_value #8

Merged
merged 2 commits into from
Aug 31, 2023
Merged

Conversation

markheik
Copy link
Collaborator

No description provided.

@markheik markheik requested a review from tobiasah August 31, 2023 07:31
@markheik markheik self-assigned this Aug 31, 2023
@markheik markheik force-pushed the markush/test_session_node_set branch from c313163 to 34130c8 Compare August 31, 2023 08:10
@markheik markheik changed the title Tests for Session set_value, update type annotations Tests for Session set_value Aug 31, 2023
TODO: To accept list of `AnnotatedValue`s

Returns:
Annotated value of the server response.

Raises:
LabOneConnectionError: If there is a problem in the connection.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to also state the exceptions that can come from unwarp,to_capnp and from capnp

src/labone/core/session.py Outdated Show resolved Hide resolved
src/labone/core/session.py Outdated Show resolved Hide resolved
src/labone/core/session.py Outdated Show resolved Hide resolved
tests/core/test_value.py Outdated Show resolved Hide resolved
@markheik markheik force-pushed the markush/test_session_node_set branch 2 times, most recently from f550d63 to 00219e2 Compare August 31, 2023 10:50
@markheik markheik force-pushed the markush/test_session_node_set branch from 00219e2 to 801b365 Compare August 31, 2023 10:54
@markheik markheik merged commit 79bfcae into main Aug 31, 2023
3 of 6 checks passed
@markheik markheik deleted the markush/test_session_node_set branch December 15, 2023 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants